feat(upload): add exponential backoff to retry logic #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
requested changes
Oct 20, 2025
There was a problem hiding this comment.
I don't love this, I'm not really convinced we need this, it's a normal process of waiting for piece parking, IMO backoff is good for error conditions, but this isn't an error condition, all this will do is make it longer for a piece park wait to happen
blocking this for now, needs more consideration before merging, maybe someone else wants to make a stronger argument for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the polling logic in the
StorageContextclass to use exponential backoff with jitter when waiting for a piece to be "parked" (ready).Fixes #293
Improvements to polling and retry logic:
baseDelay,maxDelay, and anattemptcounter to increase the delay between retries.